Mostly Grey former ginger with a preference for Rust. Leads wg-rustup, sorry about the mess. He/Him or They/Their Now @kinnison@fosstodon.org too
Manchester
Joined December 2008
- Tweets 12,967
- Following 105
- Followers 493
- Likes 1,386
e.g. I'm much more proud of the commit messages in github.com/kinnison/marked-yโฆ than I am of past projects.
1
Past me was a dick who wrote bad commit messages. Present me is trying to do better so that future me doesn't hate present me quite so much when he's past me :D
1
1
Heck yes, good commit messages are valuable, though sometimes a one-liner is sufficient tbf. What I hate is people who don't clean up their commits, I view commits as a way to break down a change to understand it better; and as a forward-view to when you have to `git blame`.
1
That you do that pre-PR code review for yourself is a wonderful thing. Encouraging my colleagues to actually *look* at what they're proposing before they ask others to review it has been a theme of my last 2 years of work :D
2
1
1
Things can be used in huge success stories and still be thought of as awful by some. cf. C, C++, Java, Windows, etc.
1
TFW you look at MyFitnessPal and realise that a pint of halo top is within your remaining calorie budget for the day.
2
I'm sure there'll be a new stage of joy waiting for you, but I'm glad you're making progress. Sleep well.
Reasons to love SSDs nr 12652
When you are overcome with toe-tapping goodness on the hifi, your laptop doesn't get sad at being bounced around while it's compiling stuff.
4
Fortunately this library is pretty much 100% data manipulation so I don't think I need much in the way of mocking, but that's useful ideas to put in my toolbelt.
1
Yeah that's how I feel I ought to be treating this -- the doctests just show that I've not written bad examples. I'm just trying to decide between unit tests and integration tests for this. Perhaps I should sleep on the problem :D
1
I think that's a good way of thinking about it yes. Right now all my testing is doctests because I just wrote those while writing the crate - but I feel I ought to have more formal testing too.
1
1
Yeah, but where do I draw the line when 99% of the API is public? Do I bother with unit tests for specific testing, or do I try and cover all the code by means of integration tests? What about examples, do they count for coverage, or not? Such are my Monday evening ponderings.
2
1
Yeah, for non-public content, unit tests makes perfect sense; but given 99% of the library is public API, I wonder if it ought to be in tests/*.rs
1
1