“warning: unsafe function's docs miss `# Safety` section” yes yes @dsilverstone already said that good grief

ooh a bug in clippy warning: you should consider adding a `Default` implementation for `bmpvec::BmpVec<T>` help: try this impl Default for bmpvec::BmpVec<T> { dear clippy, i think you want impl<T> there, and also i don’t want the bmpvec prefix inside mod bmpvec

If you can construct a minimal example of it being wrong, please file a bug. The clippy people will appreciate it.

hmm the warning doesn't trigger on the obvious simple example play.rust-lang.org/?version=… 🤷‍♂️

When you're otherwise done, point me at your codebase and I'll see if I can dig something out :D

clippy was complaining about the lack of impl Default before i added it to dotat.at/cgi/git/dnstrie.git…

Hmm, I get paste.rs/TsS which suggests that the problem was already likely fixed. What toolchain are you using? I'm on 1.52.1

i just updated from 1.52.0 to 1.52.1 and the mistake is still there ah nightly has impl<T> rather than bare impl, but it still has the wrong item path

oh and actually your paste shows both bugs: if you copy clippy’s suggestion into the code in place of my impl Default, it won’t compile

Iiinteresting. Clippy still mentions the submodule name but gets the impl<T>. rust-analyzer's create-default-impl-from-new doesn't insert the submodule name but misses the <T> off the impl.