Pre-pull request self code review: Why did I call this function that? Why did I put those functions in this file instead of that file where they obviously belong? This other block clearly doesn't do what the spec defined. Guess I'll wait on that pull request then.
1
1
Programming is a lot like sending an email. Read what you wrote three times before sending.
3
2
That you do that pre-PR code review for yourself is a wonderful thing. Encouraging my colleagues to actually *look* at what they're proposing before they ask others to review it has been a theme of my last 2 years of work :D
2
1
1
I should also note I got into the habit of using `git add -p` to review what I'm committing and stage chunks at a time, then `git diff --cached` to be really sure before I commit :-)
1
Replying to @jogbert
That is a good technique, and something I use too :D

Jan 23, 2020 ยท 1:11 PM UTC

1