"Absence of negative comments is in itself a positive thing" is not an attitude I want to adopt for doing code reviews
2
1
3
Replying to @Lynoure
Indeed, nothing positive to say => +0 on a code review -- i.e. not a +1.

Mar 26, 2019 ยท 9:17 AM UTC

1
1
Replying to @dsilverstone
There seems to be a belief that merge request tools are meant to be only used to point at things to correct. I am guessing not many FLOSS projects would survive consistently using them so.
1
1
Mmm, I tend to accept that commenting directly on code in MR tools is usually for hilighting something which needs attention. I use comments on the MR itself to say something along the lines of "This looks excellent, thank you" or whatever. But I get your point for sure.
1