Interesting, useful and funny read by @jgbbrd on Stacked Diffs Versus Pull Requests jg.gg/2018/09/29/stacked-difโ€ฆ Lots to learn about good practice even when using PRs. Rebase interactive FTW
1
I've had to try several times to read the article due to the number of outright lies and miscommunications in the first few sections. In the end I had to stop because: whether or not "Stacked Diffs" are any good, the supercilious ultracrepidation overruled any possible value.
1
Could you be more specific for my own benefit and education? :-)
3
Replying to @Violetilla @jgbbrd
First sentence of the fourth paragraph of the next section about how engineers don't work on easily broken down work just suggests that author's workplace doesn't do a good job of work planning and this leads them to make a sweeping statement which is false.

Oct 5, 2018 ยท 10:04 AM UTC

2
Replying to @dsilverstone @Violetilla @jgbbrd
I'll admit that beyond that, I just give up. There's an assumption that engineers are unable to operate Git efficiently, which is sad, and that by piling up loads of semi-unrelated changes on one branch you get something you can confidently submit for review which seems odd.
2
All in all it's very sad because the article has some good points related to producing integral changes which can be reviewed as a whole. But it's couched in so much sensationalist nonsense that the message gets lost.
2
more replies
Replying to @dsilverstone @jgbbrd
Yes, once again, I think he may mention it at some point in the article, I think it doesn't mean that PR is bad and creates those problems, it's more like, humans are terrible and don't care enough, so PRs allow bad practices to carry away easier.
1