Mostly Grey former ginger with a preference for Rust. Leads wg-rustup, sorry about the mess. He/Him or They/Their Now @kinnison@fosstodon.org too
Manchester
Joined December 2008
- Tweets 12,967
- Following 105
- Followers 493
- Likes 1,386
Have finally set up the Occulus CV1 I bought off my colleague. Elite:Dangerous is even more pretty now \o/
Reason number 2.
If you choose to rebase regularly to keep up, you spend a *LOT* of time rebasing.
1
Reasons why long-lived branches are difficult to work with number 1.
Master moves on, you do not. The rebase gets more and more painful the longer you live.
1
1
1
So long as the +1s outweigh the -0s, and there are no -1s, it's a mergeable thing.
We tend to look for 2 +1s too.
I think that kind of thing is quite hard to pin down. I tend to use "+1/+0/-0/-1" as a scale, where "+1" is "I like this, it should merge" "+0" is "I think this is okay, if someone else likes it it should merge" "-0" is "this smells bad but I won't block" and "-1" is "Hells no"
1
1
Though I don't agree that devs on your own team should get to bypass PRs -- Even in a team of excellent engineers, things get spotted by others which would otherwise get through.
1
This is one reason why I distinguish "Change review" which is done on PR/MRs and "Code review" which is done on the codebase as a whole in a periodic/incremental manner.
1
1